Need advice about which tool to choose?Ask the StackShare community!
ESLint vs PullReview: What are the differences?
ESLint: The fully pluggable JavaScript code quality tool. A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease; PullReview: Automated code review for Ruby and Rails developers. PullReview helps Ruby and Rails developers to develop new features cleanly, on-time, and with confidence by automatically reviewing their code.
ESLint and PullReview can be categorized as "Code Review" tools.
"IDE Integration" is the top reason why over 2 developers like ESLint, while over 17 developers mention "Very detailed review of my code" as the leading cause for choosing PullReview.
ESLint is an open source tool with 14.4K GitHub stars and 2.46K GitHub forks. Here's a link to ESLint's open source repository on GitHub.
Scenario: I want to integrate Prettier in our code base which is currently using ESLint (for .js and .scss both). The project is using gulp.
It doesn't feel quite right to me to use ESLint, I wonder if it would be better to use Stylelint or Sass Lint instead.
I completed integrating ESLint + Prettier, Planning to do the same with [ Stylelint || Sasslint || EsLint] + Prettier.
And have gulp 'fix' on file save (Watcher).
Any recommendation is appreciated.
In the case of .js files I would recommend using both Eslint and Prettier.
You can set up Prettier as an Eslint rule using the following plugin:
https://github.com/prettier/eslint-plugin-prettier
And in order to avoid conflicts between Prettier and Eslint, you can use this config:
https://github.com/prettier/eslint-config-prettier
Which turns off all Eslint rules that are unnecessary or might conflict with Prettier.
Pura vida! Well, I had a similar issue and at the end I decided to use Stylelint + Prettier for that job, in our case, we wanted that our linting process includes the SCSS files and not only the JS file, base on that we concluded that using only ESLint to do both things wasn't the best option, so, we integrated prettier with Stylelint, and for that we used a neat plugin that allowed us to use Prettier inside Stylelint here is the link, https://github.com/prettier/stylelint-prettier#recommended-configuration, I hope that this can help you, hasta pronto!, :)
you don't actually have to choose between these tools as they have vastly different purposes. i think its more a matter of understanding how to use them.
while eslint and stylelint are used to notify you about code quality issues, to guide you to write better code, prettier automatically handles code formatting (without notifying me). nothing else.
prettier and eslint both officially discourage using the eslint-plugin-prettier way, as these tools actually do very different things. autofixing with linters on watch isnt a great idea either. auto-fixing should only be done intentionally. you're not alone though, as a lot of devs set this up wrong.
i encourage you to think about what problem you're trying to solve and configure accordingly.
for my teams i set it up like this: - eslint, stylelint, prettier locally installed for cli use and ide support - eslint config prettier (code formatting rules are not eslints business, so dont warn me about it) - vscode workspace config: format on save - separate npm scripts for linting, and formatting - precommit hooks (husky)
so you can easily integrate with gulp. its just js after all ;)
Pros of ESLint
- Consistent javascript - opinions don't matter anymore8
- Free6
- IDE Integration6
- Customizable4
- Focuses code review on quality not style2
- Broad ecosystem of support & users2
Pros of PullReview
- Very detailed review of my code18
- Useful10
- Github integration9
- Feels like a teacher is helping me7
- Up to date inspections5
- Ease of setup5
- Free for OSS5
- Fix the problems before they reach the master branch4
- Just awesome3
- Rails only2
- Pullreview just made our life so much easier1
- Relevant SO discussions1