Need advice about which tool to choose?Ask the StackShare community!
ESLint vs Gerrit Code Review: What are the differences?
1. Linting Tool: ESLint is a linting tool that helps developers identify and fix problems in their JavaScript code based on a set of predefined rules, while Gerrit Code Review is a code review tool that facilitates collaborative code reviews among developers. 2. Integration with IDEs: ESLint can be integrated with various Integrated Development Environments (IDEs) such as Visual Studio Code, Sublime Text, and Atom, providing real-time feedback to developers as they write code. On the other hand, Gerrit Code Review is often used independently of IDEs and is primarily focused on reviewing code changes made by developers. 3. Code Quality Focus: ESLint's primary focus is on enforcing code quality and best practices by detecting potential errors or style inconsistencies in the codebase, ensuring that the code meets certain standards. In contrast, Gerrit Code Review focuses on reviewing code changes for correctness, functionality, and adherence to project-specific guidelines. 4. Automated vs. Manual Review: ESLint performs automated static code analysis to identify issues in the code automatically without human intervention, whereas Gerrit Code Review requires manual inspection and approval by human reviewers before changes are merged into the codebase. 5. Continuous Integration: ESLint can be seamlessly integrated into a Continuous Integration (CI) pipeline to enforce code quality standards across the development workflow, while Gerrit Code Review provides a platform for conducting code reviews as part of the development process within the version control system. 6. Scope of Use: ESLint is primarily used during the development phase to catch issues early and improve code quality, whereas Gerrit Code Review is used during the code review process to ensure that changes are thoroughly evaluated before merging them into the codebase.
In Summary, ESLint focuses on code quality enforcement through automated static analysis, while Gerrit Code Review facilitates manual code reviews for correctness and collaboration among developers.
Scenario: I want to integrate Prettier in our code base which is currently using ESLint (for .js and .scss both). The project is using gulp.
It doesn't feel quite right to me to use ESLint, I wonder if it would be better to use Stylelint or Sass Lint instead.
I completed integrating ESLint + Prettier, Planning to do the same with [ Stylelint || Sasslint || EsLint] + Prettier.
And have gulp 'fix' on file save (Watcher).
Any recommendation is appreciated.
In the case of .js files I would recommend using both Eslint and Prettier.
You can set up Prettier as an Eslint rule using the following plugin:
https://github.com/prettier/eslint-plugin-prettier
And in order to avoid conflicts between Prettier and Eslint, you can use this config:
https://github.com/prettier/eslint-config-prettier
Which turns off all Eslint rules that are unnecessary or might conflict with Prettier.
you don't actually have to choose between these tools as they have vastly different purposes. i think its more a matter of understanding how to use them.
while eslint and stylelint are used to notify you about code quality issues, to guide you to write better code, prettier automatically handles code formatting (without notifying me). nothing else.
prettier and eslint both officially discourage using the eslint-plugin-prettier way, as these tools actually do very different things. autofixing with linters on watch isnt a great idea either. auto-fixing should only be done intentionally. you're not alone though, as a lot of devs set this up wrong.
i encourage you to think about what problem you're trying to solve and configure accordingly.
for my teams i set it up like this: - eslint, stylelint, prettier locally installed for cli use and ide support - eslint config prettier (code formatting rules are not eslints business, so dont warn me about it) - vscode workspace config: format on save - separate npm scripts for linting, and formatting - precommit hooks (husky)
so you can easily integrate with gulp. its just js after all ;)
Pura vida! Well, I had a similar issue and at the end I decided to use Stylelint + Prettier for that job, in our case, we wanted that our linting process includes the SCSS files and not only the JS file, base on that we concluded that using only ESLint to do both things wasn't the best option, so, we integrated prettier with Stylelint, and for that we used a neat plugin that allowed us to use Prettier inside Stylelint here is the link, https://github.com/prettier/stylelint-prettier#recommended-configuration, I hope that this can help you, hasta pronto!, :)
Pros of ESLint
- Consistent javascript - opinions don't matter anymore8
- Free6
- IDE Integration6
- Customizable4
- Focuses code review on quality not style2
- Broad ecosystem of support & users2
Pros of Gerrit Code Review
- Code review13
- Good workflow11
- Cleaner repository story10
- Open source9
- Good integration with Jenkins9
- Unlimited repo support5
- Comparison dashboard2
Sign up to add or upvote prosMake informed product decisions
What is ESLint?
What is Gerrit Code Review?
Need advice about which tool to choose?Ask the StackShare community!
What companies use Gerrit Code Review?
Sign up to get full access to all the companiesMake informed product decisions
What tools integrate with Gerrit Code Review?
Sign up to get full access to all the tool integrationsMake informed product decisions
Blog Posts
+43