Do you review your Pull/Merge Request before assigning Reviewers?

If you work in a team opening a Pull Request (or Merge Request) looks appropriate. However, have you ever thought about opening a Pull/Merge Request when working by yourself? Here's a checklist of things you can review in your own:

• Pick the correct target branch
• Make Drafts explicit
• Name things properly
• Ask help for tools
• Remove the noise
• Fetch necessary data
• Understand Mergeability
• Pass the message
• Add screenshots
• Be found in the future
• Comment inline in your changes

Read the blog post for more detailed explanation for each item :D

What else do you review before asking for code review?

Using an inclusive language is crucial for fostering a diverse culture. Git has changed the naming conventions to be more language-inclusive, and so you should change. Our development tools, like GitHub and GitLab, already supports the change.

SourceLevel deals very nicely with repositories that changed the master branch to a more appropriate word. Besides, you can use the grep linter the look for exclusive terms contained in the source code.

As the inclusive language gap may happen in other aspects of our lives, have you already thought about them?

One of the magic tricks git performs is the ability to rewrite log history. You can do it in many ways, but git rebase -i is the one I most use. With this command, It’s possible to switch commits order, remove a commit, squash two or more commits, or edit, for instance.

It’s particularly useful to run it before opening a pull request. It allows developers to “clean up” the mess and organize commits before submitting to review. If you follow the practice 3 and 4, then the list of commits should look very similar to a task list. It should reveal the rationale you had, telling the story of how you end up with that final code.

Out of most of the VCS solutions out there, we found Gitlab was the most feature complete with a free community edition. Their DevSecops offering is also a very robust solution. Gitlab CI/CD was quite easy to setup and the direct integration with your VCS + CI/CD is also a bonus. Out of the box integration with major cloud providers, alerting through instant messages etc. are all extremely convenient. We push our CI/CD updates to MS Teams.

Gitlab as A LOT of features that GitHub and Azure DevOps are missing. Even if both GH and Azure are backed by Microsoft, GitLab being open source has a faster upgrade rate and the hosted by gitlab.com solution seems more appealing than anything else! Quick win: the UI is way better and the Pipeline is way easier to setup on GitLab!

My website is brand new and one of the few requirements of testings I had to implement was code coverage. Never though it was so hard to implement using a #docker container. Given my lack of experience, every attempt I tried on making a simple code coverage test using the 4 combinations of #TravisCI, #CircleCi with #Coveralls, #Codecov I failed. The main problem was I was generating the .coverage file within the docker container and couldn't access it with #TravisCi or #CircleCi, every attempt to solve this problem seems to be very hacky and this was not the kind of complexity I want to introduce to my newborn website. This problem was solved using a specific action for #GitHubActions, it was a 3 line solution I had to put in my github workflow file and I was able to access the .coverage file from my docker container and get the coverage report with #Codecov.

We were long time users of TravisCI, but switched to CircleCI because of the better user interface and pricing. Version 2.0 has had a couple of trips and hiccups; but overall we've been very happy with the continuous integration it provides. Continuous Integration is a must-have for building software, and CircleCI continues to surprise as they roll out ideas and features. It's leading the industry in terms of innovation and new ideas, and it's exciting to see what new things they keep rolling out.

Jenkins is a pretty flexible, complete tool. Especially I love the possibility to configure jobs as a code with Jenkins pipelines.

CircleCI is well suited for small projects where the main task is to run continuous integration as quickly as possible. Travis CI is recommended primarily for open-source projects that need to be tested in different environments.

And for something a bit larger I prefer to use Jenkins because it is possible to make serious system configuration thereby different plugins. In Jenkins, I can change almost anything. But if you want to start the CI chain as soon as possible, Jenkins may not be the right choice.

At DeployPlace we use self-hosted GitLab, we have chosen GitLab as most of us are familiar with it. We are happy with all features GitLab provides, I can’t imagine our life without integrated GitLab CI. Another important feature for us is integrated code review tool, we use it every day, we use merge requests, code reviews, branching. To be honest, most of us have GitHub accounts as well, we like to contribute in open source, and we want to be a part of the tech community, but lack of solutions from GitHub in the area of CI doesn’t let us chose it for our projects.